Try to understand useBlockSync #57074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -25 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c2831cd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7212199478
|
ellatrix
commented
Dec 14, 2023
| // been reset we need to take the blocks again from the external | ||
| // value property. | ||
| pendingChanges.current.outgoing = []; | ||
| setControlledBlocks(); |
There was a problem hiding this comment.
@youknowriad I'm trying to understand if this change is fine or not. No tests are failing.
The areInnerBlocksControlled state is only set by the setHasControlledInnerBlocks action. And that action is only used twice in the code base, both in this file. It's only ever called once with false, which is here. So we can simply move the code here instead of using useSelect and a useEffect?
I'm not sure how to test, and I'm not sure if there's e2e test missing for this.
There was a problem hiding this comment.
Anyway, inner blocks are not controlled that often, so in terms of performance this is probably negligible. But still it's a bit simpler if possible.
There was a problem hiding this comment.
This function unsetControlledBlocks is only called when the block list is unmounted. I know for sure that there are some block that can change from "uncontrolled" to "controlled" while being mounted. So I think this change is probably breaking something.
That said reading the code, I wonder if we could just do this instead const isControlled = ! clientId && value !== undefined; to avoid the useSelect
There was a problem hiding this comment.
I forgot how to trigger it but I think the "navigation" block can move from uncontrolled to controlled while being mounted. I'm also certain that there is another use-case but can't find it right now.
There was a problem hiding this comment.
This subscription is not so important, it's only for controlled blocks anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast