Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code style in Gutenberg_HTML_Tag_Processor_6_5 #57030

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix code style in Gutenberg_HTML_Tag_Processor_6_5 #57030

merged 1 commit into from
Dec 13, 2023

Conversation

anton-vlasenko
Copy link
Contributor

What?

This PR fixes code style in the Gutenberg_HTML_Tag_Processor_6_5 class.

Why?

The class contains excess space characters.

How?

I've removed these excess space characeters.

Testing Instructions

Make sure that CI jobs pass.

Testing Instructions for Keyboard

Screenshots or screencast

@anton-vlasenko anton-vlasenko added the [Type] Code Quality Issues or PRs that relate to code quality label Dec 13, 2023
@github-actions GitHub Actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/html-api/class-gutenberg-html-tag-processor-6-5.php

hellofromtonya
hellofromtonya approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @anton-vlasenko 🥇

@anton-vlasenko anton-vlasenko mentioned this pull request Dec 13, 2023
Merged
@hellofromtonya hellofromtonya enabled auto-merge (squash) December 13, 2023 17:39
@hellofromtonya
Copy link
Contributor

I enabled auto-merge. Once the CI jobs are all green, it'll merge this PR into trunk.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited
Loading

Flaky tests detected in 5268dd3.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7198813621
📝 Reported issues:

@anton-vlasenko anton-vlasenko merged commit 4844fe9 into trunk Dec 13, 2023
55 checks passed
@anton-vlasenko anton-vlasenko deleted the fix/space-character-in-html-tag-processor branch December 13, 2023 18:03
@github-actions github-actions bot added this to the Gutenberg 17.4 milestone Dec 13, 2023
@dmsnell
Copy link
Member

dmsnell commented Dec 13, 2023

@hellofromtonya might be best not to enable auto-merge, as this PR is good in covering a lint error, but the fix needs to originate in Core and be backported here, ideally.

@anton-vlasenko do you plan on pushing the change to Core? please cc me in the Trac ticket/GH PR and I'll review.

sadly this adds confusion when we diverge in Gutenberg ahead of the HTML API in Core.

@anton-vlasenko anton-vlasenko mentioned this pull request Dec 14, 2023
Closed
@anton-vlasenko
Copy link
Contributor Author

anton-vlasenko commented Dec 14, 2023 •
edited
Loading

@anton-vlasenko do you plan on pushing the change to Core? please cc me in the Trac ticket/GH PR and I'll review.

Yes, I do. Thank you for the ping, @dmsnell.

Trac ticket: https://core.trac.wordpress.org/ticket/60078
Core backport PR: WordPress/wordpress-develop#5768

@anton-vlasenko anton-vlasenko added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 14, 2023
artemiomorales pushed a commit that referenced this pull request Jan 4, 2024
@anton-vlasenko @artemiomorales
Fix code style in Gutenberg_HTML_Tag_Processor_6_5. (#57030)
2f93c0a
@getdave getdave mentioned this pull request Jan 18, 2024
Closed
@getdave getdave added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Jan 22, 2024
@getdave
Copy link
Contributor

getdave commented Jan 22, 2024 •
edited
Loading

@anton-vlasenko It looks this was already backported prior to the upcoming WP 6.5 Beta 1. Therefore I've adjusted the labels to denote this.

Are you happy that the code is in Core and ready for WP 6.5?

@anton-vlasenko
Copy link
Contributor Author

Yes, I'm happy, @getdave. The fewer pending PRs to backport, the better.
Thanks for the ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellofromtonya hellofromtonya hellofromtonya approved these changes

@dmsnell dmsnell Awaiting requested review from dmsnell dmsnell is a code owner

Assignees
No one assigned
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 17.4
Development

Successfully merging this pull request may close these issues.
4 participants
@anton-vlasenko @hellofromtonya @dmsnell @getdave