Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Styles for Social Icons list placeholders #56887

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Improve Styles for Social Icons list placeholders #56887

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3019546
updated styles for placeholders
colinduwe Dec 8, 2023
522eea7
added classes and styles to placeholders so they respond to color con…
colinduwe Dec 8, 2023
e405e37
Fix linting
cbravobernal Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix linting
  • Loading branch information
@cbravobernal
cbravobernal committed Oct 15, 2024
commit e405e37246934b9272d939f958b51abc3d5558ee
8 changes: 4 additions & 4 deletions packages/block-library/src/social-links/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export function SocialLinksEdit( props ) {
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [ logosOnly ] );

const placeholderClasses = classNames( 'wp-social-link', {
const placeholderClasses = clsx( 'wp-social-link', {
[ `has-${ iconColor.slug }-color` ]: iconColor.slug,
[ `has-${ iconBackgroundColor.slug }-background-color` ]:
iconBackgroundColor.slug,
Expand All @@ -104,21 +104,21 @@ export function SocialLinksEdit( props ) {
<li className="wp-block-social-links__social-placeholder">
<div className="wp-block-social-links__social-placeholder-icons">
<div
className={ classNames(
className={ clsx(
'wp-social-link-twitter',
placeholderClasses
) }
style={ placeholderStyles }
></div>
<div
className={ classNames(
className={ clsx(
'wp-social-link-facebook',
placeholderClasses
) }
style={ placeholderStyles }
></div>
<div
className={ classNames(
className={ clsx(
'wp-social-link-instagram',
placeholderClasses
) }
Expand Down
Loading