-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keycodes: avoid regex for capital case #56822
Conversation
Size Change: +1.19 kB (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
Flaky tests detected in b588209. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7134236844
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks
* @param {string} string String to capitalise. | ||
* @return {string} Capitalised string. | ||
*/ | ||
function capitaliseFirstCharacter( string ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor language nit: since in web we generally go with the US conventions, I'd alter capitalise
to capitalize
.
function capitaliseFirstCharacter( string ) { | |
function capitalizeFirstCharacter( string ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Although I personally favour the s spelling, we should keep names consistent and greppable, @ellatrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, looks like I forgot to fix it
Note that the failed test only needs to have the snapshot updated and it actually makes more sense the new way. |
What?
I saw
capitalCase
pop up in the performance graph, probably because of the regex, so I thought I'd quickly address it. It seems way overkill to pull in a package for this, and add a regex on top of that. Let's just usetoUpperCase
.Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast