-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Add a first block type page to the platform docs #56109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. Just left some minor suggestions.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good to me. I also left a couple of other minor suggestions.
Thanks!
registerBlockType( 'create-block/gutenpride', { | ||
// This is just a flag that tells the block editor that this block | ||
// is using the API version 3 (the latest block type API). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: How will the "latest block type API" comment age in these docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming that we will always encourage folks to use the latest apiVersion, so I expect a lookup for apiVersion
within our markdown files every time we add a new version.
Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
Related #53874
What?
This just bootstrap the "create block type" tutorial for the "Gutenberg as a framework" docs. It starts by using the same example from the WordPress specific docs without all the WordPress specific jargon and APIs.