Delete unused SelectedBlockPopover component
#55821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
|
Flaky tests detected in e583492. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6737046134
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Deletes an unused component. The
<SelectedBlockPopover />was refactored into two new components:<SelectedBlockTools />and<EmptyBlockInserter />in #55737 as seen at https://github.com/WordPress/gutenberg/pull/55737/files#diff-d6d7994ce45fa28128923423e19291abd7de2fad164752f0f068cb9bfa93f4a0.As #55712 also touched the
<SelectedBlockPopover />and was merged later, the file got re-added even though it's not needed.Why?
It is unneeded so, let's delete it.
How?
Delete it :)
Testing Instructions
All tests should pass. If everything builds and all tests pass, then things are working fine here.
Testing Instructions for Keyboard
Screenshots or screencast