-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File block: Add typography block support #55693
Open
carolinan
wants to merge
15
commits into
trunk
Choose a base branch
from
add/file-block-typography-support
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−9
Open
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7ed7ea0
File block: Add typography block supports
carolinan cb93b13
Remove the default font size.
carolinan 81c94e8
Replace the faulty blockProps with the style property
carolinan 28837a8
Merge branch 'trunk' into add/file-block-typography-support
carolinan 8d993e0
Add typograhy to block-editor native hooks
carolinan 081fc44
Merge branch 'trunk' into add/file-block-typography-support
carolinan 62771da
Merge branch 'trunk' into add/file-block-typography-support
carolinan e17e2ef
Try to fix spacing CS issue in save.js
carolinan 3d8bf85
Merge branch 'trunk' into add/file-block-typography-support
carolinan ab316c7
Merge branch 'trunk' into add/file-block-typography-support
carolinan 0d8ec02
Merge branch 'trunk' into add/file-block-typography-support
carolinan c7d3185
Merge branch 'trunk' into add/file-block-typography-support
carolinan 3facf4b
Merge branch 'trunk' into add/file-block-typography-support
carolinan bc0ecd6
Merge branch 'trunk' into add/file-block-typography-support
carolinan 48b6740
Merge branch 'trunk' into add/file-block-typography-support
carolinan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
File block: Add typography block supports
- Loading branch information
commit 7ed7ea075e754f8cb2d58f0c9429f237155a20b8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason for adding these manually. Isn't this something that the hook adds automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because I needed the typography class names and inline styles to be on both the wrapper, and the download button.
If I only use the save props on the wrapper, or if I try to use an experimental selector for the typography in block.json, then the button styles override the user settings from the controls in the block editor.