Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Ensure uploaded audio is always visible within Audio block #55627

Merged
merged 12 commits into from
Nov 16, 2023
Prev Previous commit
Next Next commit
Fallback to device style if theme styles undefined
As described in the following feedback, there can be times when the editor background colour returns an "undefined" string: #55627

With this commit, that case is accounted for, with the default dark/light styles being applied.
  • Loading branch information
Siobhan committed Nov 3, 2023
commit e83f5c688c2b46c66d5559d1f373419aa64ef2e5
5 changes: 4 additions & 1 deletion packages/components/src/mobile/audio-player/index.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ function Player( {
const editorColors = globalStyles?.baseColors?.color;
const editorBackgroundColor = editorColors?.background;

if ( typeof editorBackgroundColor === 'undefined' ) {
if (
typeof editorBackgroundColor === 'undefined' ||
editorBackgroundColor === 'undefined'
) {
return getStylesFromColorScheme( baseStyle, darkStyle );
}

Expand Down
Loading