Revert "Patterns: fix capabilities settings for pattern categories #55532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.4/block-patterns.php ❔ lib/compat/wordpress-6.4/blocks.php ❔ lib/load.php |
|
If we do revert this we will need to then reimplement this one change in a new PR following that revert to allow author and contributor users to view the user category lists - and this change will need to be backported. |
|
Size Change: -919 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
glendaviesnz
added
[Feature] Patterns
|
Flaky tests detected in 66c11af. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6599119077
|
|
For awareness @SiobhyB, this revert is needed for the npm packages update for 6.4 RC2. |
hellofromtonya
approved these changes
Oct 23, 2023
Once this revert is merged, @glendaviesnz notes a follow-up fix is needed for |
|
@hellofromtonya the PR for the fix that needs to be included in 6.4 is here - I will get one of our team to review it, but may not be until tomorrow, but it is pretty straightforward so feel free to review and merge if you have time. |
|
Thank you @glendaviesnz! Once PR #55553, it can be cherry-picked for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5b10d27.
What?
Reverts the changes made in #55379 that prevents Author level users from adding pattern categories.
Why?
It was thought that Authors should be able to choose from existing categories but not add new ones, and this is probably still the idea, but there are potential issues with modifying the taxonomy capabilities to disallow this, as mentioned here. The best option is probably to back this out and leave it with authors able to add new pattern categories at this point in the 6.4 release cycle.
How?
A straight revert of 5b10d27.
Testing Instructions