-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Appium 2 Migration #55166
[Mobile] Appium 2 Migration #55166
Commits on Oct 6, 2023
-
- Bumps Appium to version 2.0.0 - Removes wd in favor of WebdriverIO
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 9ebbc40 - Browse repository at this point
Copy the full SHA 9ebbc40View commit details -
- Adds appium:setup script to install needed drivers for Appium.
- Updates test:e2e:build-wda with the new Appium home path for the xcuitest driver. - Updates test:e2e:android:local and test:e2e:ios:local to add the newly added appium:setup script to install drivers if needed.
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 8b5af07 - Browse repository at this point
Copy the full SHA 8b5af07View commit details -
Update Android Runner to cache the Appium drivers
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 009346b - Browse repository at this point
Copy the full SHA 009346bView commit details -
Update iOS Runner - Bump Xcode to 14.2
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 5f9b11a - Browse repository at this point
Copy the full SHA 5f9b11aView commit details -
Update iOS Runner with these changes:
- Move the Launch of the simulator step to the top so it starts booting up the simulator in the background, so it doesn't block the next steps while it's stating. - Install and cache the Appium drivers.
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for c4a9b2e - Browse repository at this point
Copy the full SHA c4a9b2eView commit details -
Updates the E2E capabilities settings:
- It removes unneeded values after the migration. - Bumps the iOS platform version to 16.2. - Adds specific SauceLabs configuration that sets the Appium version to 2.0.0. - Adds a prefixKeysWithAppium util to append the "appium:" prefix for the Appium capabilities settings. This is added to simplify the modifications we do for some of the settings in runtime.
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for b03f738 - Browse repository at this point
Copy the full SHA b03f738View commit details -
Updates the E2E serverConfigs file with the updated SauceLabs setting…
…s for Appium 2 and WebdriverIO
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 4d02fe1 - Browse repository at this point
Copy the full SHA 4d02fe1View commit details -
- Remove import of wd and set it as null temporarily while we migrate its usage to WebdriverIO
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 70d400a - Browse repository at this point
Copy the full SHA 70d400aView commit details -
Update getIOSPlatformVersions to get the desired platform version from the capabilities settings instead of an inline value
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for f52a355 - Browse repository at this point
Copy the full SHA f52a355View commit details -
- Update Remote configuration with the new structure for WebdriverIO and Appium 2 - Uses the prefixKeysWithAppium util for the Appium capabilities, we cannot use "appium:options" since that's only available for real devices and we use simulators instead. - The app capability value was updated to the new storage:filename= prefix this was important to make SauceLabs to work correctly
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for c80e54b - Browse repository at this point
Copy the full SHA c80e54bView commit details -
E2E Utils - Update the stopDriver function with:
- Changes sessionID to sessionId - Removes the hash value to append in the Job URL, these URLs are public so it's not needed to append the auth param. - Updates driver.quit() to driver.deleteSession()
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for da3fdbe - Browse repository at this point
Copy the full SHA da3fdbeView commit details -
E2E Utils - Updates swipeFromTo to WebdriverIO
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 0f241cf - Browse repository at this point
Copy the full SHA 0f241cfView commit details -
E2E Utils - Updates isEditorVisible to WebdriverIO
It adds a custom timeout to waitForDisplayed, the simulators in CI are slow so we need to give enough time to find the post title locator.
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 23dfa7c - Browse repository at this point
Copy the full SHA 23dfa7cView commit details -
Remove usage of sauceJobStatus, WebdriverIO internally handles this
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for e09e15c - Browse repository at this point
Copy the full SHA e09e15cView commit details -
EditorPage - Remove import of wd and keep a null value while we migra…
…te to WebdriverIO
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for f9c55ef - Browse repository at this point
Copy the full SHA f9c55efView commit details -
EditorPage - Migrate initializeEditor to WebdriverIO
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for ff802a4 - Browse repository at this point
Copy the full SHA ff802a4View commit details -
Gutenberg Editor Rendering Media Blocks test - Migrate to WebdriverIO
Gerardo committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 024afb2 - Browse repository at this point
Copy the full SHA 024afb2View commit details
Commits on Oct 10, 2023
-
E2E Utils - Revert removing passing the auth token for the jobURL, it…
… also updates the logic to the latest implementation from SauceLabs docs.
Gerardo committedOct 10, 2023 Configuration menu - View commit details
-
Copy full SHA for 9db690e - Browse repository at this point
Copy the full SHA 9db690eView commit details -
Remove idleTimeout desktop-only SauceLabs option
Gerardo committedOct 10, 2023 Configuration menu - View commit details
-
Copy full SHA for f6f0cef - Browse repository at this point
Copy the full SHA f6f0cefView commit details -
[Mobile] - Update E2E Block Insertion tests (#55167)
* E2E Utils, updates the typing helpers: - Removes the platform specfic typing functionality in favor of WebdriverIO's addValue * E2E Utils - Updates getKeycode and pressKeycode to WebdriverIO * E2E Utils - Update tapStatusBariOS to WebdriverIO * E2E Utils - Update toggleHtmlMode to WebdriverIO * E2E Utils - Update waitForVisible to WebdriverIO * E2E Editor Page - Update getBlockAtPosition to WebdriverIO * E2E Editor Page - Update getTitleElement to WebdriverIO * E2E Editor Page - Update getHtmlContent to WebdriverIO * E2E Editor Page - Update swipeToolbarToElement to WebdriverIO * E2E Editor Page - Update addNewBlock to WebdriverIO * E2E Editor Page - Update findBlockButton to WebdriverIO * E2E Editor Page - Update assertSlashInserterPresent to WebdriverIO * E2E EditorPage - Update waitForElementToBeDisplayedById to WebdriverIO * E2E Test - Block Insertion - Update to WebdriverIO * Update typeString scroll delay comment Co-authored-by: David Calhoun <github@davidcalhoun.me> --------- Co-authored-by: David Calhoun <github@davidcalhoun.me>
Configuration menu - View commit details
-
Copy full SHA for d1ce7b3 - Browse repository at this point
Copy the full SHA d1ce7b3View commit details -
test: Update Search tests for Appium 2 (#55170)
* test: Update getSearchBlockTextElement query Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade. * test: Update waitForElementToBeDisplayedByXPath query Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade. * test: Update verifySearchElementText query Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade. * test: Update getSearchBlockTextElement query Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade.
Configuration menu - View commit details
-
Copy full SHA for 35293d9 - Browse repository at this point
Copy the full SHA 35293d9View commit details
Commits on Oct 11, 2023
-
E2E Editor Page - Update dismissKeyboard to use WebdiverIO's hideKeyb…
…oard (#55211)
Gerardo Pacheco authoredOct 11, 2023 Configuration menu - View commit details
-
Copy full SHA for 3027b7e - Browse repository at this point
Copy the full SHA 3027b7eView commit details -
test: Update Media Blocks tests for Appium 2 (#55222)
* test: Replace sleep with pause utility Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade. * test: Replace elementsByAccessibilityId usage Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade. * test: Replace elementByXPath usage Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade. * test: Repair enterCaptionToSelectedImageBlock utility Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade. Additionally, the `clearValue` method did not succeed on the caption Button element. Hence, the utility was expanded to instead type into the TextView.
Configuration menu - View commit details
-
Copy full SHA for 9ffbe9a - Browse repository at this point
Copy the full SHA 9ffbe9aView commit details -
test: Update Paragraph tests for Appium 2 (#55215)
* test: Update clickMiddleOfElement helper Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade. * test: Update clickBeginningOfElement helper Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade. * test: Update getTextForParagraphBlockAtPosition helper Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade. * test: Replace elementsByXPath usage Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade.
Configuration menu - View commit details
-
Copy full SHA for db1605b - Browse repository at this point
Copy the full SHA db1605bView commit details -
E2E Utils - Migrate dragAndDropAfterElement to WebdriverIO (#55254)
Gerardo Pacheco authoredOct 11, 2023 Configuration menu - View commit details
-
Copy full SHA for ced4287 - Browse repository at this point
Copy the full SHA ced4287View commit details -
[Mobile] - Move Appium drivers setup to bash script (#55257)
* Move Appium drivers setup to bash script * Update drivers' names casing for consistency * Rename appium:setup to test:e2e:setup
Gerardo Pacheco authoredOct 11, 2023 Configuration menu - View commit details
-
Copy full SHA for b384a3b - Browse repository at this point
Copy the full SHA b384a3bView commit details
Commits on Oct 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 12f876a - Browse repository at this point
Copy the full SHA 12f876aView commit details
Commits on Oct 16, 2023
-
test: Update E2E utilities (#55322)
* test: Set static device pixel ratio WebdriverIO (the replacement for the deprecated WD driver library) does not have a method for retrieving a device's pixel ratio. Therefore, this sets an explicit value for each of our test devices. * test: Update the `getAddBlockButton` utility Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade. * test: Update toggleDarkMode utility Seems this method has changed or been removed for Android. * test: Increase robustness of waitForKeyboardToBeHidden utility This utility appeared to fail occasionally due to an empty `addButton` value. * test: toggleDarkMode uses consistent approach across platforms This updates the iOS variant to mirror the structure of the Android variant in the name of consistency. * refactor: Rename devicePixelRatio to pixelRatio Mirror Android implementation found in Appium 2. * test: Increase logging levels Attempt to debug CI failures. ``` FAIL __device-tests__/gutenberg-editor-rendering-media-blocks.test.js (73.496 s) ● Gutenberg Editor Rendering Media Blocks test › should be able to render blocks correctly unknown method: Not implemented at getErrorFromResponseBody (file:/Users/runner/work/gutenberg/gutenberg/node_modules/webdriver/build/utils.js:194:12) at NodeJSRequest._request (file:/Users/runner/work/gutenberg/gutenberg/node_modules/webdriver/build/request/index.js:164:23) at Browser.wrapCommandFn (file:/Users/runner/work/gutenberg/gutenberg/node_modules/@wdio/utils/build/shim.js:81:29) ``` * refactor: Prefer `action` to `touchAction` Avoid the deprecated `touchAction` command. > The `touchAction` command is deprecated and will be removed in a future version. We recommend to use the action command instead with pointer type touch, e.g.: > > await browser.action('pointer', { > parameters: { pointerType: 'touch' } > }) https://webdriver.io/docs/api/element/touchAction/ This may also relate to the fact that Mobile JSON Wire Protocol is deprecated as well. > Mobile JSON Wire Protocol > > The Mobile JSON Wire Protocol is a super set of mobile commands on top of the JSON Wire Protocol. Given this one is deprecated the Mobile JSON Wire Protocol also got deprecated. Appium might still support some of its commands but it is not recommended to use them. https://webdriver.io/docs/api/protocols#mobile-json-wire-protocol * Revert "test: Increase logging levels" This reverts commit 7bb46de. * test: Set default `swipeFromTo` delay value This prevents `pause` from being called without a parameter, which throws an error.
Configuration menu - View commit details
-
Copy full SHA for c545e8f - Browse repository at this point
Copy the full SHA c545e8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dbf082 - Browse repository at this point
Copy the full SHA 0dbf082View commit details
Commits on Oct 18, 2023
-
test: Replace swipe gesture with simple tap (#55427)
It was unclear as to why the swipe gesture failed to close the bottom sheet, but a simple tap towards the middle-top of the display achieves the same result.
Configuration menu - View commit details
-
Copy full SHA for d482aa0 - Browse repository at this point
Copy the full SHA d482aa0View commit details
Commits on Oct 19, 2023
-
[Mobile] - Appium 2 Migration - Updating more utils (#55420)
* Updates the longPressMiddleOfElement util by using WebdriverIO's action. It adds tapping on the element first before long-pressing due to an issue with iOS not triggering the long-press event. The default waitTime was reduced as well to 1000. * Update selectTextFromElement to WebdriverIO. It also changes the logic for iOS where it uses the "Select All" option from the context menu instead of using "doubleTap". Timeouts have been reduced as well. * Refactors selectTextFromElement for Android, the previous implementation would only select the word that was located in the middle of the element, with the new changes it will select all text by long-pressing from the start of the element to the end. Unfortunately we can't access the context menu as we do on iOS so it has to be done manually. * Add inline duration value and adds inline comments to explain the functionality
Gerardo Pacheco authoredOct 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 1bde2af - Browse repository at this point
Copy the full SHA 1bde2afView commit details -
[Mobile] - Update closePicker util and updates Image Block test data (#…
…55484) * Update closePicker util name to closeMediaPicker, it also unifies the logic for both platforms by having the same locator and using WebdriverIO's waitForDisplayed. * Update test data for the image block, by changing the image caption to avoid issues in CI and autocorrect
Gerardo Pacheco authoredOct 19, 2023 Configuration menu - View commit details
-
Copy full SHA for d36cf9c - Browse repository at this point
Copy the full SHA d36cf9cView commit details -
[Mobile] Improve Screen recording on Android for Appium 2 (#55443)
* Improve Screenrecording on Android by making sure of the following: The sdcard folder should exist in the emulator, if not there's a script that will create it. For skipped tests, it will remove empty folders that weren't needed. When having multiple Android emulators opened, it will use the deviceID that Appium is currently using. * Rename getAndroidDeviceID function to getDeviceID since it's not platform specific * Fix comment * Temp: log session * Use adb devices list to get the first active android emulator * Moves getAndroidEmulatorID to its own file and replaces its usage. It also adds specifying the device ID for Android local builds for cases when multiple devices/emulators are connected. * Remove unneeded filtering * Move setting the androidDeviceID value for Android cases only
Gerardo Pacheco authoredOct 19, 2023 Configuration menu - View commit details
-
Copy full SHA for efecd41 - Browse repository at this point
Copy the full SHA efecd41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d3b48a - Browse repository at this point
Copy the full SHA 1d3b48aView commit details
Commits on Oct 23, 2023
-
docs: Update E2E test documentation (#55519)
* docs: Rewrite end-to-end testing documentation Update for breaking changes from upgrading Appium 2. Reduce verbosity and duplication to improve the approachability and maintainability of the documentation. * docs: Remove E2E test contributing documentation This was replaced by a section in the directory's README documentation. * docs: Rewrite end-to-end testing Getting Started section Update for breaking changes from upgrading Appium 2. Reduce verbosity and duplication between the `WordPress/gutenberg` repository to improve the approachability and maintainability of the documentation. * docs: Update links in Gutenberg for Mobile Apps code documentation Documents have been updated and consolidated to reduce verbosity and duplication to improve the approachability and maintainability of the documentation.
Configuration menu - View commit details
-
Copy full SHA for 15e4023 - Browse repository at this point
Copy the full SHA 15e4023View commit details -
[Mobile] Remove
wd
usage and removes disabled tests (#55541)* Device tests - Removes skipped tests that haven't been enabled back for a while. These were disabled due to flakiness most likely to the interactions with the context menu to copy/paste text. If needed this can be restored once the flakiness issues are worked on. * Device Tests - Drag & Drop: removes disabled tests. These used utils that were flaky and have been disabled for a long time, they can be added back once stable utils are in place for pasting content. * Editor Page - Removes setHtmlContent since this util is not being used anymore. It can be added back if its needed. * Device Tests Utils - Removes usage of the wd library. It also removes, doubleTap, clickElementOutsideOfTextInput, and related utils to the context menu due to them being flaky and not currenlty in use: tapSelectAllAboveElement, tapCopyAboveElement and tapPasteAboveElement.
Gerardo Pacheco authoredOct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 7f99ec7 - Browse repository at this point
Copy the full SHA 7f99ec7View commit details -
Merge branch 'trunk' into rnmobile/appium-2
Gerardo committedOct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for b37ad19 - Browse repository at this point
Copy the full SHA b37ad19View commit details
Commits on Oct 24, 2023
-
test: Improve E2E test consistency (#55554)
* test: Mitigate conflicts between development server caches Occasionally, cryptic npm package dependency errors can occur between test runs. They appear to originate from stale development caches, e.g. Metro server. Clearing these caches, which E2E tests should not rely upon mitigates the likelihood of these errors. * test: Prefix informative E2E test setup logs Merely an attempt to add structure to the outputted logs. * test: Avoid setup scripts during test runs There may be clarity and efficiency by having an explicit setup script. It was avoid running unnecessary scripts during test runs. It is also referenced in the current documentation as a script to run intentionally.
Configuration menu - View commit details
-
Copy full SHA for 9d4613a - Browse repository at this point
Copy the full SHA 9d4613aView commit details -
build: Ignore generated Android files (#55569)
These assets are generated at build time for E2E testing. Seemingly, we do not leverage these generated files for the binary/bundle that we provide to the host apps. Therefore, we can safely ignore these files.
Configuration menu - View commit details
-
Copy full SHA for 52b04f1 - Browse repository at this point
Copy the full SHA 52b04f1View commit details -
docs: Avoid GMA project name until it is approved
Use of the "Gutenberg for Mobile Apps" name is still under review. In the meantime, we should use the existing "Mobile Gutenberg" project name.
Configuration menu - View commit details
-
Copy full SHA for 020bb1b - Browse repository at this point
Copy the full SHA 020bb1bView commit details