Template Parts: Add a replace flow to the inspector controls #55128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Enhancement
scruffian
requested review from
draganescu,
jameskoster,
richtabor and
carolinan
|
Size Change: +217 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fc12186. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8007028292
|
I would expect the relevant patterns assigned to the block type to also render as options here, like see in the choose modal.
|
scruffian
force-pushed
the
add/replace-tp-in-inspector-controls
branch
from
49ce2ef
to
20cb955
Compare
This is what we are doing :) |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
commented
Feb 20, 2024
| mapTemplatePartToBlockPattern( templatePart ) | ||
| ); | ||
|
|
||
| const onTemplatePartSelect = ( templatePart ) => { |
There was a problem hiding this comment.
This is also defined in packages/block-library/src/template-part/edit/selection-modal.js, but I think they are simple enough that it's ok.
MaggieCabrera
approved these changes
Feb 22, 2024
scruffian
force-pushed
the
add/replace-tp-in-inspector-controls
branch
from
919083f
to
b9959b2
Compare
|
This is cool. I feel like there's some relationship between this PR and the shuffling PR #59251 |
|
The perf here is still not good. On an M1 it takes seconds for the async list to show more possibilities. Maybe we need also a visual indicator in place. Plus that the UI is still frozen for a bit. |
There's certainly overlap, as noted in the other thread, there is with content only and pattern overrides as well. To be sure, do you mainly mean showing the "Replace" panel in the inspector for anything that can be shuffled? Could make sense, especially if we can improve the performance. It might even fit well in the Settings tab, as there's usually space there: |
That way works too but I was thinking about the other way around: adding a shuffle button to the block toolbar of the template part and use the "replace list" as alternative options. |
ellatrix
reviewed
Mar 29, 2024
| templatePartId | ||
| ); | ||
| const blockPatterns = useAlternativeBlockPatterns( area, clientId ); | ||
| const hasReplacements = !! templateParts.length || !! blockPatterns.length; |
There was a problem hiding this comment.
This sort of reverted the changes I made here: #57856. I'll make a PR to fix it.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This exposes the option to replace a template part with another, from the inspector controls for the block. This is similar to the idea in #44582.
Why?
It's already possible to do this, using the "replace" option in the More Settings for the block in the toolbar, but this isn't very discoverable, so adding it to the inspector controls makes it easier to do.
How?
Just add block previews in the sidebar and then hook them up to the setAttribute function to switch the slugs for the template part.
Testing Instructions
Screenshots or screencast
Questions