[RNMobile] Quote block: Ensure border is visible with block-based themes in dark mode #54964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
SiobhyB
added
Mobile App - i.e. Android or iOS
geriux
approved these changes
Oct 10, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Partial fix for #50666, ensures that the Quote block's left border is always visible.
Why?
There are certain scenarios where the Quote block's left border is currently invisible. This happens if a block-based theme has a light background (which the native editor displays) and the device has dark mode enabled, and vice versa.
How?
If a block-based theme is active, the theme's text colour will be detected and used for the block's left border.
Testing Instructions
Testing Instructions for Keyboard
N/A, this is a visual change only.
Screenshots or screencast