Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try fixing the flaky 'Toolbar roving tabindex' e2e test #54785

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Try fixing the flaky 'Toolbar roving tabindex' e2e test #54785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2449d8f
Try fixing the flaky 'Toolbar roving tabindex' e2e test
Mamaduka Sep 25, 2023
29f31df
Add link in the comment
Mamaduka Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/e2e/specs/editor/various/toolbar-roving-tabindex.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ test.describe( 'Toolbar roving tabindex', () => {
await admin.createNewPost();
await editor.insertBlock( { name: 'core/paragraph' } );
await page.keyboard.type( 'First block' );

// Ensure the fixed toolbar option is off.
// See: https://github.com/WordPress/gutenberg/pull/54785.
await editor.setIsFixedToolbar( false );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could we add a link to the original issue just to give confidence to others to remove this line if we ever resolve the root cause? 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll link this PR; it has more context.

} );

test( 'ensures base block toolbars use roving tabindex', async ( {
Expand Down
Loading