Show block inserter to the left of empty paragraphs. #5478
Conversation
mtias
added
[Feature] Inserter
mtias
force-pushed
the
add/inserter-to-the-left-on-empty-p
branch
from
d0013e2 to
feb50d8
Compare
|
|
||
| .editor-block-list__empty-block-inserter { | ||
| position: absolute; | ||
| top: 10px; |
| @@ -11,6 +11,39 @@ $empty-paragraph-height: $text-editor-font-size * 4; | |||
| outline: 1px solid $light-gray-500; | |||
| } | |||
| } | |||
|
|
|||
| .editor-inserter-with-shortcuts { | |||
There was a problem hiding this comment.
Not sure what of it is related to changes here, but default inserter does some unexpected things at smaller viewports:
|
Columns with default appender and the new half-opacity:
|
| @@ -603,7 +604,7 @@ export class BlockListBlock extends Component { | |||
| rootUID={ rootUID } | |||
| layout={ layout } | |||
| /> | |||
| { shouldShowMovers && ( | |||
| { shouldShowMovers && ! showSideInserter && ( | |||
There was a problem hiding this comment.
Seems like ! showSideInserter ought to be built-in to the condition assigning to shouldShowMovers, if we're expecting them to be mutually exclusive (prevents future errors where this is not accounted for).
|
We need more space for these columns :) @jasmussen thoughts? |
|
Simplified mobile to be:
|
|
This is 🔥 Can you add
How are you doing the mobile stuff? I'm still seeing this:
Also, there's a fair bit of right margin on mobile breakpoints. Given that we have a desire to revisit the side UI for both mobile and nested — it's on my todo list but is blocked on #5217 — perhaps I can look at improving those things separately from this PR, so we don't hold these improvements up from shipping. |
|
@jasmussen is that with the latest changes? It looks like shown above to me: #5478 (comment) |
|
The issue with the |
mtias
force-pushed
the
add/inserter-to-the-left-on-empty-p
branch
2 times, most recently
from
924cfb3 to
f37a25b
Compare
This seeks to improve the usability of adding content other than text. It also removes the ellipsis menu for empty paragraphs under the assumption that it adds unnecessary noise. Once the user types anything, both the movers and menu reappear. It also bumps the number of items in the quick-shortcuts area to 3.
mtias
force-pushed
the
add/inserter-to-the-left-on-empty-p
branch
from
f37a25b to
bf439ad
Compare
|
This is what I'm seeing:
I think this is great. 👍 👍 Mobile:
Looks good too. It's slightly weird with the plus to the right on mobile, and the plus in the top left inserter. I feel like we may be able to do with just the latter, especially since the toolbar is sticky and the mobile viewport is so small. But no objections, though, good to ship 👍 👍 |
|
You did it. Looks great. |
This seeks to improve the usability of adding content other than text. It also removes the ellipsis menu for empty paragraphs under the assumption that it adds unnecessary noise.
Once the user types anything, both the movers and menu reappear.
It also bumps the number of items in the quick-shortcuts area to 3 given the inserter has moved.