Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Export ProgressBar to allow it to be used" #54428

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Revert "Export ProgressBar to allow it to be used" #54428

merged 2 commits into from
Sep 13, 2023

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Sep 13, 2023 •
edited
Loading

Reverts #54404

See explanation from #54404 (comment)

cc @matiasbenedetto

@ciampo ciampo requested a review from tyxla September 13, 2023 13:08
@ciampo ciampo self-assigned this Sep 13, 2023
@ciampo ciampo added [Package] Components /packages/components [Type] New API New API to be used by plugin developers or package users. labels Sep 13, 2023
@ciampo
Copy link
Contributor Author

ciampo commented Sep 13, 2023

Noting that the CHANGELOG CI check is expected to fail for this PR, since we actually want to remove an entry (without adding one)

tyxla
tyxla approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Instead we should be using the lock/unlock mechanism, as done here:

gutenberg/packages/edit-site/src/components/canvas-loader/index.js

Line 15 in 2af5a24

const { ProgressBar, Theme } = unlock( componentsPrivateApis );

@ciampo ciampo enabled auto-merge (squash) September 13, 2023 13:11
@ciampo ciampo merged commit 1c2f437 into trunk Sep 13, 2023
49 of 50 checks passed
@ciampo ciampo deleted the revert-54404-add/progress-bar-export branch September 13, 2023 14:40
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@ciampo ciampo

Labels
[Package] Components /packages/components [Type] New API New API to be used by plugin developers or package users.
Projects
WordPress Components
Status: Done 🎉
Milestone
Gutenberg 16.7
Development

Successfully merging this pull request may close these issues.
2 participants
@ciampo @tyxla