Backport tools: filter PRs to be cherry picked by merged date #54171
Merged
Backport tools: filter PRs to be cherry picked by merged date #54171
Conversation
… then use by merged_at
tellthemachines
approved these changes
Sep 5, 2023
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
LGTM! This should prevent PRs closed without merging from accidentally getting cherry-picked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
A follow up to:
This PR removes the
closed_atfallback when remapping fetched PRs.Why?
We only want merged PRs so we filter then use by
merged_at.closed_atmight catch closed PRs that have not been merged.Testing Instructions
As in #52667 you can test against any set of Gutenberg PR labels on a test branch by running
npm run other:cherry-pick "LABEL_NAME"npm run other:cherry-pickalone will run against the "Backport to WP Beta/RC" label.