Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Block: Adds --target-dir flag to allow the tool to target where to scaffold #53781

Merged
merged 12 commits into from
Oct 28, 2024
Merged

Create Block: Adds --target-dir flag to allow the tool to target where to scaffold #53781

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1c7782b
Add --targetDir flag to allow targeting a directory where to scaffold…
ryanwelcher Aug 17, 2023
1e61305
Not using the targetDir when in --no-plugin mode
ryanwelcher Aug 17, 2023
be2f1e0
Change the name of the flag to match others and update changelog.
ryanwelcher Aug 17, 2023
e9bbebc
WIP commit.
ryanwelcher Oct 24, 2024
d208749
Add logic to generate the paths for the root and block files in one p…
ryanwelcher Oct 25, 2024
d5bb756
Add a new parameter to allow passing the path once rather than genera…
ryanwelcher Oct 25, 2024
c36c6ba
Modify the other functions to use the generated paths.
ryanwelcher Oct 25, 2024
cc6a070
Update the command description.
ryanwelcher Oct 25, 2024
5d5582d
Update packages/create-block/CHANGELOG.md
gziolo Oct 28, 2024
32f0c16
Refactor the handling for the root directory
gziolo Oct 28, 2024
cad88f2
Improve the documentation for target dir
gziolo Oct 28, 2024
b90de4a
Reorder CLI options in the docs
gziolo Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a new parameter to allow passing the path once rather than genera… 
…ting it in the function.
  • Loading branch information
@ryanwelcher
ryanwelcher committed Oct 25, 2024
commit d5bb7565da3eedada79671d4cfbc3a68aa7bc5d7
18 changes: 7 additions & 11 deletions packages/create-block/lib/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,20 @@ const { render } = require( 'mustache' );
const { writeFile } = require( 'fs' ).promises;

const writeOutputAsset = async ( inputFile, outputFile, view ) => {
const outputFilePath = join( view.slug, 'assets', outputFile );
const outputFilePath = join( view.rootDirectory, 'assets', outputFile );
await makeDir( dirname( outputFilePath ) );
writeFile( outputFilePath, inputFile );
};

const writeOutputTemplate = async ( inputFile, outputFile, view ) => {
const outputFilePath = view.plugin
? join(
view.targetDir,
view.slug,
outputFile.replace( /\$slug/g, view.slug )
)
: outputFile;
await makeDir( dirname( outputFilePath ) );
const writeOutputTemplate = async ( inputFile, outputFile, view, path ) => {
await makeDir( path );
// If the rendered template is empty, don't write it. This is how we can conditionally add template files.
const renderedFile = render( inputFile, view );
if ( renderedFile.trim().length ) {
writeFile( outputFilePath, renderedFile );
writeFile(
join( path, outputFile.replace( /\$slug/g, view.slug ) ),
renderedFile
);
}
};

Expand Down