Dependencies: Update @testing-library/react to v14 #53682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Automated Testing
|
Size Change: -48 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
This is likely not the real reason. Instead, I noticed that the But do you know how we can use |
|
Thanks, @jsnajdr, that's even better! The
That's a great idea, looking forward to experiencing the test speed improvements 🚀 |
Cool, and the new suggestions to use high-level methods like |
jsnajdr
approved these changes
Aug 16, 2023
if it's really all green again now.
Indeed, and we benefit from them immediately after upgrading, that's why I wanted to use the recommended set of ESLint rules when enabling the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates
@testing-library/reactto v14.Why?
It's been a while since we migrated to React 18, and we're even using the latest
@testing-library/user-event, but we have been using an obsolete@testing-library/reactversion for a while now.How?
We're bumping
@testing-library/reactto v14 and adding an override to use@testing-library/dom@9because, without it, we'll end up using@testing-library/dom@8because of its peer dependencies, and that will cause hundreds of tests to fail (see this for more info). We're also fixing a test to use string instead of regex for querying by roles, because that's one of the breaking changes in v9 of@testing-library/dom.Testing Instructions
Verify all checks are green and tests pass.
Testing Instructions for Keyboard
None.
Screenshots or screencast
None.