Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom patterns label to 'My patterns' #51949

Merged
merged 2 commits into from
Jun 28, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -33,6 +33,7 @@ const noop = () => {};
// Preferred order of pattern categories. Any other categories should
// be at the bottom without any re-ordering.
const patternCategoriesOrder = [
'custom',
'featured',
'posts',
'text',
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ import { store as blockEditorStore } from '../../../store';

const CUSTOM_CATEGORY = {
name: 'custom',
label: __( 'Custom patterns' ),
label: __( 'My patterns' ),
description: __( 'Custom patterns add by site users' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to double-check this description.

};

Original file line number Diff line number Diff line change
@@ -67,7 +67,7 @@ export function ReusableBlocksTab( { rootClientId, onInsert, onHover } ) {
post_type: 'wp_block',
} ) }
>
{ __( 'Manage custom patterns' ) }
{ __( 'Manage my patterns' ) }
</Button>
</div>
</>
2 changes: 1 addition & 1 deletion packages/core-commands/src/admin-navigation-commands.js
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ export function useAdminNavigationCommands() {
} );
useCommand( {
name: 'core/manage-reusable-blocks',
label: __( 'Manage all custom patterns' ),
label: __( 'Manage all of my patterns' ),
callback: () => {
document.location.href = 'edit.php?post_type=wp_block';
},
6 changes: 3 additions & 3 deletions packages/edit-site/src/components/page-library/utils.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
export const DEFAULT_CATEGORY = 'header';
export const DEFAULT_TYPE = 'wp_template_part';
export const DEFAULT_CATEGORY = 'my-patterns';
export const DEFAULT_TYPE = 'wp_block';
export const PATTERNS = 'pattern';
export const TEMPLATE_PARTS = 'wp_template_part';
export const USER_PATTERNS = 'wp_block';
export const USER_PATTERN_CATEGORY = 'custom-patterns';
export const USER_PATTERN_CATEGORY = 'my-patterns';

export const CORE_PATTERN_SOURCES = [
'core',
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ import { useSelect } from '@wordpress/data';
import { getTemplatePartIcon } from '@wordpress/editor';
import { __ } from '@wordpress/i18n';
import { getQueryArgs } from '@wordpress/url';
import { file } from '@wordpress/icons';
import { file, starFilled } from '@wordpress/icons';

/**
* Internal dependencies
@@ -23,6 +23,7 @@ import { DEFAULT_CATEGORY, DEFAULT_TYPE } from '../page-library/utils';
import { store as editSiteStore } from '../../store';
import { useLink } from '../routes/link';
import usePatternCategories from './use-pattern-categories';
import useMyPatterns from './use-my-patterns';
import useTemplatePartAreas from './use-template-part-areas';

const templatePartAreaLabels = {
@@ -41,6 +42,7 @@ export default function SidebarNavigationScreenLibrary() {
const { templatePartAreas, hasTemplateParts, isLoading } =
useTemplatePartAreas();
const { patternCategories, hasPatterns } = usePatternCategories();
const { myPatterns, hasPatterns: hasMyPatterns } = useMyPatterns();

const isTemplatePartsMode = useSelect( ( select ) => {
const settings = select( editSiteStore ).getSettings();
@@ -58,7 +60,7 @@ export default function SidebarNavigationScreenLibrary() {
href="edit.php?post_type=wp_block"
withChevron
>
{ __( 'Manage all custom patterns' ) }
{ __( 'Manage all of my patterns' ) }
</SidebarNavigationItem>
</ItemGroup>
) : undefined;
@@ -86,6 +88,23 @@ export default function SidebarNavigationScreenLibrary() {
</Item>
</ItemGroup>
) }
{ hasMyPatterns && (
<ItemGroup className="edit-site-sidebar-navigation-screen-library__group">
<CategoryItem
key={ myPatterns.name }
count={ myPatterns.count }
label={ myPatterns.label }
icon={ starFilled }
id={ myPatterns.name }
type="wp_block"
isActive={
currentCategory ===
`${ myPatterns.name }` &&
currentType === 'wp_block'
}
/>
</ItemGroup>
) }
{ hasTemplateParts && (
<ItemGroup className="edit-site-sidebar-navigation-screen-library__group">
{ Object.entries( templatePartAreas ).map(
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/**
* WordPress dependencies
*/
import { store as coreStore } from '@wordpress/core-data';
import { useSelect } from '@wordpress/data';
import { __ } from '@wordpress/i18n';

export default function useMyPatterns() {
const myPatterns = useSelect( ( select ) =>
select( coreStore ).getEntityRecords( 'postType', 'wp_block', {
per_page: -1,
} )
);

return {
myPatterns: {
count: myPatterns?.length || 0,
name: 'my-patterns',
label: __( 'My patterns' ),
},
hasPatterns: !! myPatterns?.length,
};
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
/**
* WordPress dependencies
*/
import { store as coreStore } from '@wordpress/core-data';
import { useSelect } from '@wordpress/data';
import { useMemo } from '@wordpress/element';
import { __ } from '@wordpress/i18n';

/**
* Internal dependencies
@@ -15,11 +12,6 @@ import useThemePatterns from './use-theme-patterns';
export default function usePatternCategories() {
const defaultCategories = useDefaultPatternCategories();
const themePatterns = useThemePatterns();
const userPatterns = useSelect( ( select ) =>
select( coreStore ).getEntityRecords( 'postType', 'wp_block', {
per_page: -1,
} )
);

const patternCategories = useMemo( () => {
const categoryMap = {};
@@ -48,17 +40,8 @@ export default function usePatternCategories() {
}
} );

// Add "Your Patterns" category for user patterns if there are any.
if ( userPatterns?.length ) {
categoriesWithCounts.push( {
count: userPatterns.length || 0,
name: 'custom-patterns',
label: __( 'Custom patterns' ),
} );
}

return categoriesWithCounts;
}, [ defaultCategories, themePatterns, userPatterns ] );
}, [ defaultCategories, themePatterns ] );

return { patternCategories, hasPatterns: !! patternCategories.length };
}