[RNMobile] Add media inserter blocks to toolbar #51827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
Mobile App - i.e. Android or iOS
derekblank
changed the title
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 28fbc2f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5474736122
|
geriux
reviewed
Jun 26, 2023
packages/edit-post/src/components/header/header-toolbar/index.native.js
Outdated
Show resolved
Hide resolved
packages/edit-post/src/components/header/header-toolbar/index.native.js
Outdated
Show resolved
Hide resolved
packages/edit-post/src/components/header/header-toolbar/index.native.js
Outdated
Show resolved
Hide resolved
geriux
reviewed
Jun 30, 2023
packages/edit-post/src/components/visual-editor/test/index.native.js
Outdated
Show resolved
Hide resolved
13 tasks
geriux
reviewed
Jul 4, 2023
packages/edit-post/src/components/visual-editor/test/index.native.js
Outdated
Show resolved
Hide resolved
geriux
reviewed
Jul 4, 2023
packages/edit-post/src/components/visual-editor/test/index.native.js
Outdated
Show resolved
Hide resolved
geriux
reviewed
Jul 4, 2023
packages/edit-post/src/components/header/header-toolbar/index.native.js
Outdated
Show resolved
Hide resolved
geriux
reviewed
Jul 4, 2023
There was a problem hiding this comment.
Hey @derekblank nice work on these changes so far! I've left a couple of comments let me know what you think.
Functionality wise, this is working as expected 🚀
geriux
approved these changes
Jul 5, 2023
derekblank
changed the base branch from
rnmobile/feature/editor-ux-round-1
to
trunk
# Conflicts: # packages/react-native-editor/CHANGELOG.md
geriux
removed
the
Mobile App - Automation
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds buttons to insert media blocks (Image, Video, Gallery, Audio) from the mobile header toolbar when a block is not selected.
Why?
Allows users to quickly add media when writing a post without opening the Inserter.
How?
In the header toolbar component, this PR adds buttons for four media blocks, and allows the creation/insertion of each block directly from the toolbar.
Testing Instructions
Screenshots or screencast
Note: The "Add Blocks" inserter button, undo/redo buttons, and media icons will be modified in subsequent PRs.
Screen.Recording.2023-06-23.at.12.48.37.pm.mov