Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Options: Use consistent capitalization on template parts and patterns #51761

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Block Options: Use consistent capitalization on template parts and patterns #51761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08a41dd
"Create Template part" to "Create template part"
richtabor Jun 21, 2023
5f4bd96
"Create a Pattern" to "Create pattern"
richtabor Jun 21, 2023
4e66475
Tests
richtabor Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/e2e-test-utils/src/create-reusable-block.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const createReusableBlock = async ( content, title ) => {
await page.keyboard.type( content );

await clickBlockToolbarButton( 'Options' );
await clickMenuItem( 'Create a Pattern' );
await clickMenuItem( 'Create pattern' );
const nameInput = await page.waitForSelector(
reusableBlockNameInputSelector
);
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/specs/editor/various/block-editor-keyboard-shortcuts.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ describe( 'block editor keyboard shortcuts', () => {
} );
it( 'should prevent deleting multiple selected blocks from inputs', async () => {
await clickBlockToolbarButton( 'Options' );
await clickMenuItem( 'Create a Pattern' );
await clickMenuItem( 'Create pattern' );
const reusableBlockNameInputSelector =
'.reusable-blocks-menu-items__convert-modal .components-text-control__input';
const nameInput = await page.waitForSelector(
Expand Down
4 changes: 2 additions & 2 deletions packages/e2e-tests/specs/editor/various/reusable-blocks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ describe( 'Reusable blocks', () => {

// Convert block to a reusable block.
await clickBlockToolbarButton( 'Options' );
await clickMenuItem( 'Create a Pattern' );
await clickMenuItem( 'Create pattern' );

// Set title.
const nameInput = await page.waitForSelector(
Expand Down Expand Up @@ -383,7 +383,7 @@ describe( 'Reusable blocks', () => {

// Convert to reusable.
await clickBlockToolbarButton( 'Options' );
await clickMenuItem( 'Create a Pattern' );
await clickMenuItem( 'Create pattern' );
const nameInput = await page.waitForSelector(
reusableBlockNameInputSelector
);
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/template-part-converter/convert-to-template-part.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export default function ConvertToTemplatePart( { clientIds, blocks } ) {
setIsModalOpen( true );
} }
>
{ __( 'Create Template part' ) }
{ __( 'Create template part' ) }
</MenuItem>
{ isModalOpen && (
<CreateTemplatePartModal
Expand Down
4 changes: 2 additions & 2 deletions ...eusable-blocks/src/components/reusable-blocks-menu-items/reusable-block-convert-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,11 @@ export default function ReusableBlockConvertButton( {
icon={ symbol }
onClick={ () => setIsModalOpen( true ) }
>
{ __( 'Create a Pattern' ) }
{ __( 'Create pattern' ) }
</MenuItem>
{ isModalOpen && (
<Modal
title={ __( 'Create a Pattern' ) }
title={ __( 'Create pattern' ) }
onRequestClose={ () => {
setIsModalOpen( false );
setTitle( '' );
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/specs/site-editor/template-part.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ test.describe( 'Template Part', () => {
await editor.selectBlocks( paragraphBlock1, paragraphBlock2 );

// Convert block to a template part.
await editor.clickBlockOptionsMenuItem( 'Create Template part' );
await editor.clickBlockOptionsMenuItem( 'Create template part' );
await page.type( 'role=dialog >> role=textbox[name="Name"i]', 'Test' );
await page.keyboard.press( 'Enter' );

Expand Down