Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the bottom sticky section in the site editor details panel #51274

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Update the bottom sticky section in the site editor details panel #51274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/edit-site/src/components/sidebar-navigation-screen/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
}

.edit-site-sidebar-navigation-screen__content {
margin: 0 0 $grid-unit-20 0;
color: $gray-400;
padding: 0 $grid-unit-20;
.components-item-group {
Expand Down Expand Up @@ -88,9 +87,10 @@
bottom: 0;
background-color: $gray-900;
gap: 0;
padding: $grid-unit-40 0;
margin: $grid-unit-40 $grid-unit-20;
padding: $grid-unit-20 0;
margin: $grid-unit-20 0 0;
border-top: 1px solid $gray-800;
box-shadow: 0 #{-$grid-unit-10} $grid-unit-20 $gray-900;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can take or leave the shadow. I added it to be consistent with the panel header, but would just as happily remove it in both instances.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this as part of the scroll behaviour issue in a follow up.

}

.edit-site-sidebar-navigation-screen__footer {
Expand Down