-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Pagination: address feedback from #50779 #51165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
the
[Block] Query Pagination
Affects the Query Pagination Block - used for pagination within the Query Loop Block
label
Jun 1, 2023
Size Change: -19 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jun 1, 2023
ntsekouras
reviewed
Jun 1, 2023
ntsekouras
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick follow up! After addressing the minor comments I left, let's 🚢
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
Thanks for the quick review @ntsekouras! I think I've addressed your latest comments 🙇 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Query Pagination
Affects the Query Pagination Block - used for pagination within the Query Loop Block
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? / Why?
This PR addresses the feedback from @ntsekouras in #50779 post-merge.
How?
Addresses this comment:
Done ✅
Addresses this comment:
Done ✅
Testing Instructions