Navigation: Memoize link value passed to the LinkControl#51155
Merged
Navigation: Memoize link value passed to the LinkControl#51155
Conversation
Mamaduka
added
[Type] Bug
Member
Author
|
I think we should eliminate the Why?
|
|
Size Change: +10 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jun 5, 2023
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Thanks for fixing this one up @Mamaduka!
I think we should eliminate the value to internal state sync altogether.
I agree, without your explanation it would have taken me a moment to work out why this PR fixed the underlying issue. For now, though, this looks like a good temporary fix to me!
| Before | After |
|---|---|
 |
 |
LGTM! ✨
Contributor
|
I raised #51256 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #50976.
This is a regression after #50668.
PR updates the
LinkUIcomponent to pass memoized link value toLinkControland avoid losing internal state value when the component rerenders.Why?
The
LinkControluses thevalueas a source of truth; if it changes, the component resets the internal state. See #49509.The
valueis an object; we should pass referentially stable objects to avoid unnecessary state synchronizations.Testing Instructions
Screenshots or screencast
Before
CleanShot.2023-05-30.at.14.43.52.mp4
After
CleanShot.2023-06-01.at.12.28.24.mp4