Visually hide the LinkControl initial/results heading#50977
Merged
Conversation
richtabor
added
the
[Feature] Link Editing
|
Size Change: -18 kB (-1%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9c9fd3f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5124103998
|
5 tasks
getdave
reviewed
May 26, 2023
Contributor
getdave
left a comment
getdave
left a comment
There was a problem hiding this comment.
Overall this looks good. Just a small questions about the a11y implications of just using the term Links here as opposed to a more descriptive label.
packages/block-editor/src/components/link-control/search-results.js
Outdated
Show resolved
Hide resolved
3 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Use VisuallyHidden for the heading * Remove unnecessary styles * Use "Suggestions" instead of "Links" * Update Recently updated title to match Suggestions title in unit tests --------- Co-authored-by: Jerry Jones <jones.jeremydavid@gmail.com>
17 tasks
Contributor
|
By making the visual label always visually hidden, this PR violates the best practices for Will fix in the context of #65235 |
afercia
added
the
[Focus] Accessibility (a11y)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #50885 to make the LinkControl simpler.
Uses VisuallyHidden in the similar fashion in how search results are presented within the Block Inserter. Also changes the text to "Links" instead of "Recently updated" as the results consists of all sorts of links - with varying defaults.
Testing Instructions
Screenshots or screencast