Cover: Unlock private APIs outside of the component#50686
Merged
Conversation
Mamaduka
added
[Type] Code Quality
|
Size Change: +5 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
May 17, 2023
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for cleaning up that oversight @Mamaduka 👍
✅ Cover block resizing still functions correctly
✅ Code change makes sense
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Related: #50509.
PR moves unlocking of the private components outside the function.
Why?
The private components can be unlocked at the file level. There's no need to perform the action on each component re-render.
Testing Instructions
Confirm that the Cover block resizing works as before. See #41153.