Block Editor: Add names for the 'editor.BlockListBlock' filter HoCs#50513
Merged
Block Editor: Add names for the 'editor.BlockListBlock' filter HoCs#50513
Conversation
Mamaduka
added
[Type] Task
|
Size Change: +44 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c5839fa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4937225181
|
Mamaduka
force-pushed
the
add/block-list-block-filter-hoc-names
branch
from
1c83737 to
c5839fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR adds missing display names for the
editor.BlockListBlockfilter HoCs.Why?
While debugging #50292, I noticed that not all applied filter HoCs have display names. The display names make it easier to see which filters are applied to the blocks in the editor.
P.S. I hope, eventually, we'll get rid of these filters in favor of a semantic API(s).
How?
The
createHigherOrderComponentaccepts HoC display names as the second argument.Testing Instructions
editor.BlockListBlockfilters.Screenshots or screencast