Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duotone.php code cleanup #48607

Merged
merged 19 commits into from
Mar 1, 2023
Merged

duotone.php code cleanup #48607

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3d417e0
Update comment for possible duotone attribute contents
Feb 28, 2023
ece2eca
Rename filter_preset to filter_data
Feb 28, 2023
56ba1e7
Use WP_Theme_JSON for scoping the selector
Feb 28, 2023
f45e11c
Treat strings as CSS in gutenberg_get_duotone_filter_property
Feb 28, 2023
4db5028
Base is_duotone_preset based on is_string instead of !is_array
Feb 28, 2023
dc0c12d
Update comments
Feb 28, 2023
00227b8
Rename is_duotone_custom_colors
Feb 28, 2023
e127f4b
🇺🇸😉
Feb 28, 2023
0886ab7
Shorten some var names
Feb 28, 2023
cff52d1
Make each attribute case explicit
Feb 28, 2023
7b4cbf8
Only use $filter_data for custom filters
Feb 28, 2023
216a58c
Add comment about rendering the SVG
Feb 28, 2023
6e63d16
Fix php lint
Feb 28, 2023
e2e3069
Update comments
Mar 1, 2023
ffcd58a
Fix php elseifs
Mar 1, 2023
8394914
Fix CSS code path
Mar 1, 2023
659f272
Add PHP unit tests
scruffian Mar 1, 2023
e2711be
Fix php lint
Mar 1, 2023
3416969
Remove tear_down because I don't think it's used
Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove tear_down because I don't think it's used
  • Loading branch information
Alex Lende committed Mar 1, 2023
commit 3416969cf0de4ec94280732700578a8f3cd42a12
9 changes: 1 addition & 8 deletions phpunit/block-supports/duotone-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,8 @@
*/

class WP_Block_Supports_Duotone_Test extends WP_UnitTestCase {
public function tear_down() {
wp_clean_themes_cache();
unset( $GLOBALS['wp_themes'] );
WP_Style_Engine_CSS_Rules_Store_Gutenberg::remove_all_stores();
parent::tear_down();
}

public function test_gutenberg_render_duotone_support_preset() {
$block = array(
$block = array(
'blockName' => 'core/image',
'attrs' => array( 'style' => array( 'color' => array( 'duotone' => 'var:preset|duotone|slug' ) ) ),
);
Expand Down