Table: Display fixed width table cells option by default#47536
Merged
aaronrobertshaw merged 1 commit intotrunkfrom Jan 31, 2023
Merged
Table: Display fixed width table cells option by default#47536aaronrobertshaw merged 1 commit intotrunkfrom
aaronrobertshaw merged 1 commit intotrunkfrom
Conversation
This has the effect of the table displaying the settings table consistently regardless of whether it is in the placeholder state or not. The Header and Footer settings were omitted as they really don't make a lot of sense while there is no content for the table and could lead to an empty table with only the header and footer.
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +3 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Jan 30, 2023
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
What?
Renders the "Fixed width table cells" option for the table block even while it is in its placeholder state.
Why?
This has the effect of the table block consistently displaying the settings tab, regardless of whether it is in the placeholder state. The Header and Footer settings continue only to be rendered once the table has a set number of rows and columns, as they really don't make a lot of sense while there is no content for the table.
Further discussion can be found on: #47474 (comment)
How?
Move the conditional around the table's custom settings to only make the table header and footer settings conditional.
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-01-30.at.2.51.04.pm.mp4