Conversation
adamziel
added
[Type] Bug
|
Size Change: +106 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ae29f66b1ede2c02ec93e6cfc324d6edd10533ea. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4014453357
|
adamziel
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ryanwelcher
as code owners
ntsekouras
reviewed
Jan 25, 2023
…try.registerStore() and for sub registries.
…e() on the registry object
adamziel
force-pushed
the
add/lock-support-for-subregistries
branch
from
485ef83 to
3b65448
Compare
ntsekouras
approved these changes
Jan 26, 2023
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
This looks good to me, thank you Adam!
Contributor
|
Thanks Adam! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
registerPrivateActionsandregisterPrivateSelectorsonly supported stores created usingcreateReduxStore. On stores registered using the deprecatedregisterStorehelper the private actions are not returned uponunlock()-ing theuseDispatch()call (as reported by @talldan in #47375 (comment)).This PR adds the missing support for the
registerStore()stores as well as for the children stores in sub registries.Test plan
Confirm the CI checks pass, the code updates make sense, and the documentation update is easy to understand.
cc @talldan @noisysocks @ntsekouras @mcsf @Mamaduka