Global styles: move custom CSS to ellipsis menu if no custom CSS present yet#47371
Merged
glendaviesnz merged 7 commits intotrunkfrom Jan 29, 2023
Merged
Global styles: move custom CSS to ellipsis menu if no custom CSS present yet#47371glendaviesnz merged 7 commits intotrunkfrom
glendaviesnz merged 7 commits intotrunkfrom
Conversation
|
Size Change: -23.7 kB (-2%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2556a9b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4038619332
|
glendaviesnz
added
the
Global Styles
glendaviesnz
force-pushed
the
update/custom-css-move-to-menu
branch
from
69b2335 to
ea23a82
Compare
glendaviesnz
changed the title
Member
|
Works well for me. Eventually I'd like to follow up with a design improvement for the popover, but it's fine for this pass. 💪
|
Contributor
Author
@richtabor I have reordered the items as suggested. |
talldan
approved these changes
Jan 27, 2023
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Looks good, and works well. Thanks for working on this.
aristath
approved these changes
Jan 27, 2023
Contributor
|
@glendaviesnz I think this is missing the |
Contributor
Author
bph
added
Backport to Gutenberg RC
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Moves the custom CSS to the Global Styles ellipsis menu by default. Once Custom CSS has been added the option appears permanently in the sidebar.
Why?
Fixes: #47266
How?
Checks to see if
styles.cssis undefined and if so only shows Custom CSS in the global styles ellipsis menu.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
custom-css-menu.mp4