Site Editor: Force visual editor in browse mode #47329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +3 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Another option would be to trigger an action like we do here not sure what's best |
Personally I think it's fine that we preserve the previously selected editor mode, if we click |
|
Personally, I thought that the editor mode saved in the store should not be switched without explicit user intervention. Does it depend on preference which is better? 🤔 |
|
yeah, if it's a preference, the current PR is the way to go to avoid messing with that preference. |
|
I would like to know the preferences of others, who would you prefer? |
|
Let's merge this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47194
What?
This PR forces the visual editor to appear when the site editor is in browse mode.
Why?
As reported in #47194, if you switch to the code editor and then return to browse mode, the code editor is retained and you can edit the code. My understanding is that the browse mode is to check the appearance of the template, not the code, and should not be able to edit the content.
How?
In browse mode, the visual editor is displayed regardless of the editor mode setting. This PR doesn't change the mode stored in the store. This is because I believe that switching between editor modes should be done explicitly by the user.
Testing Instructions
Switch the editor mode to code editor and check the following points:
Ctrl+Shift+Alt+M⇧+⌥+⌘+MScreenshots or screencast
9c3bb470e08a88aae21bd94543deb10b.mp4