Query Loop Block: Add migration of colors to v2 deprecation#46522
Merged
ntsekouras merged 1 commit intotrunkfrom Dec 14, 2022
Merged
Query Loop Block: Add migration of colors to v2 deprecation#46522ntsekouras merged 1 commit intotrunkfrom
ntsekouras merged 1 commit intotrunkfrom
Conversation
aaronrobertshaw
added
[Type] Bug
|
Size Change: +34 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Dec 14, 2022
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
Looks good, thank you!
ryanwelcher
changed the title
ryanwelcher
changed the title
dmsnell
pushed a commit
that referenced
this pull request
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
What?
Adds missing migration of color support attributes and styles to the Query block's
v2deprecation.Why?
Fixes
v2deprecation for the Query block.How?
v2deprecation's attributes and inner blocks through an extracted util function to migrate colors.v2deprecation fixture with colors to cover this scenario.Testing Instructions
npm run test:unit test/integration/full-content/full-content.test.jsv2versions of the query block with colors set get migrated correctly in the editor