Sidebar Tabs: Use editor settings to override display#46321
Merged
Conversation
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +110 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
talldan
reviewed
Dec 6, 2022
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Pretty happy with this approach.
I personally don't think removing tabs from the link block is the long term solution to the nav block's List View interface, but it does solve the immediate problem and provides some time for more exploration into the right solution.
Nice work!
Comment on lines
76
to
82
| if ( tabSettings[ blockName ] !== undefined ) { | ||
| return tabSettings[ blockName ]; | ||
| } | ||
|
|
||
| if ( tabSettings.default !== undefined ) { | ||
| return tabSettings.default; | ||
| } |
Contributor
There was a problem hiding this comment.
So at the moment you can set default: false and something like 'core/paragraph': true to enable tabs only on one block. Or default: true and 'core/paragraph': false to disable only one block.
That's pretty flexible, and honors the individual tab setting, which is nice.
The other option might be having 'default' as a separate setting entirely instead of a property, but I don't really have a strong preference either way. I wonder if anyone has ever made a block with the name 'default', as that may cause an issue. It would be going against the block naming guidelines, which recommend namespaced block names (my-plugin/default), so probably not something to worry about.
Contributor
Author
There was a problem hiding this comment.
Thanks. I'll be happy to trial the alternative if others have stronger opinions or different thoughts.
aaronrobertshaw
requested review from
TimothyBJacobs,
ellatrix,
geriux,
spacedmonkey and
tellthemachines
as code owners
getdave
reviewed
Dec 6, 2022
Contributor
getdave
left a comment
getdave
left a comment
There was a problem hiding this comment.
Thank you so much for working on this.
Some things I spotted. Will test manually shortly...
packages/block-editor/src/components/inspector-controls-tabs/use-inspector-controls-tabs.js
Show resolved
Hide resolved
getdave
approved these changes
Dec 6, 2022
Contributor
getdave
left a comment
getdave
left a comment
There was a problem hiding this comment.
Screen.Capture.on.2022-12-06.at.11-17-23.mp4
I tested in both Site and Post editors and this worked as expected for the Nav block experiment 👏
scruffian
reviewed
Dec 6, 2022
Contributor
|
Lets address the feedback in a followup... |
Contributor
Author
|
A PR addressing the majority of feedback is up in #46346 |
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
* Sidebar Tabs: Use editor settings to override display * Roll check of tab display into use tabs hook * Disable display of tabs for Nav Submenu block
bph
added
the
Needs Dev Note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
What?
Why?
We need a means of providing plugins and third party blocks with the ability to disable the display of block inspector tabs.
How?
__experimentalBlockInspectorTabsblock_editor_settings_allfilter to the Navigation Link block to disable tabs for itAlternative Approaches
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2022-12-06.at.2.09.04.pm.mp4