Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18N: Remove blank spaces at string ends, add periods to string ends. #46091

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

I18N: Remove blank spaces at string ends, add periods to string ends. #46091

wants to merge 5 commits into from

Conversation

kebbet
Copy link
Contributor

@kebbet kebbet commented Nov 27, 2022

What?

Improvements to I18N strings on the Experimental page in the WordPress GUI.

Why?

  • Translateable strings should not end with blank spaces. They are to no use.
  • Sentences should end with a period.

How?

New strings have to be translated upstream at translate.wordpress.org

Testing Instructions

Screenshots or screencast

@kebbet kebbet requested a review from spacedmonkey as a code owner November 27, 2022 12:25
@codesandbox
Copy link

codesandbox bot commented Nov 27, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@kebbet kebbet mentioned this pull request Nov 28, 2022
Open
@t-hamano t-hamano added Internationalization (i18n) Issues or PRs related to internationalization efforts Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Nov 28, 2022
@t-hamano t-hamano linked an issue Nov 28, 2022 that may be closed by this pull request
Translateable strings in plugin containing whitespace and are missing periods. #46109
Open
@kebbet kebbet closed this Jan 31, 2023
@kebbet kebbet force-pushed the I18N-improvements-in-`Experimental`-page branch from 34ab3e4 to 04837c4 Compare January 31, 2023 15:27
@kebbet kebbet reopened this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translateable strings in plugin containing whitespace and are missing periods.
2 participants
@kebbet @t-hamano