Navigation: Add label field to navigation link and navigation submenu#45964
Merged
Navigation: Add label field to navigation link and navigation submenu#45964
Conversation
scruffian
added
[Block] Navigation
|
|
|
Size Change: +22 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
Contributor
|
Closes #45952 |
MaggieCabrera
approved these changes
Nov 22, 2022
Contributor
MaggieCabrera
left a comment
MaggieCabrera
left a comment
There was a problem hiding this comment.
This is testing nicely for me! Thanks for picking this one up
82 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add the "Label" field to the navigation link and navigation submenu inspector controls.
Why?
Since we are now allowing users to edit these blocks in the list view, we should add these controls to the inspector too.
How?
I'm doing this outside the scope of the experiment as these blocks are already hard to edit on canvas, so even if the experiment fails I think this change will be useful.
Testing Instructions
Screenshots or screencast