-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Logo: Apply width to logo container in editor #45821
Conversation
Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
Size Change: +7 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
Ahh I see, that's with a border on the Site Logo block? I've moved the width setting to the placeholder rather than the container, I believe that should fix this and make it act more similar to how it does currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works!
What?
When the width property is set in the block markup for the Site Logo block but there is no image applied, the Site Logo placeholder will default to filling the available width. This may happen if a theme or pattern specifies a set width in the block markup, for example:
Why?
Themes or patterns should be able to provide an ideal Site Logo width that is represented in the editor before an image is added. Fixes #45788.
How?
This PR applies the
width
property, if it exists, to the Site Logo placeholder in the editor.I also tried applying the width to the placeholder itself (on line 510), but this means the block container still fills 100% of the width when selected, as shown with the selected blue border. I thought it seemed like a better user experience for the entire block to be limited to the specified width.Testing Instructions
(Taken from the above issue.)
Sample markup:
Screenshots or screencast
Using the above markup:
cc @WordPress/block-themers