Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Cover Block tests to Playwright #45784

Merged
merged 17 commits into from
May 15, 2023
Merged

Migrate Cover Block tests to Playwright #45784

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
12053c5
Add new Playwright E2E tests for the cover block.
worldomonation Nov 15, 2022
4ad16be
Add comment
worldomonation Nov 15, 2022
ff1b3c3
Update block list selector
worldomonation Nov 17, 2022
1594c2d
test/e2e/specs/editor/blocks/cover.spec.js
worldomonation Apr 26, 2023
2a496d1
test/e2e/specs/editor/blocks/cover.spec.js
worldomonation Apr 27, 2023
e409acf
packages/e2e-tests/specs/editor/blocks/cover.test.js
worldomonation Apr 27, 2023
c154640
test/e2e/specs/editor/blocks/cover.spec.js
worldomonation Apr 27, 2023
071c31b
- add comment explaing use of CSS selector for '.components-resizable…
worldomonation May 10, 2023
77a1b7b
- remove testing `test.only`
worldomonation May 10, 2023
6d20287
- define the coverBlock locator after inserting the block, and use th…
worldomonation May 10, 2023
d6a4f44
- fix the import to use `import`.
worldomonation May 10, 2023
b6e5c29
- anchor selectors on a parent selector.
worldomonation May 10, 2023
8b19caf
- use the Cover block's resize handle as basis for calculation when r…
worldomonation May 10, 2023
f756ede
- remove testing "only"
worldomonation May 10, 2023
aadc65d
- check the src repeatedly to contain the fileBasename instead.
worldomonation May 10, 2023
7897f28
- move `getBackgroundColorAndOpacity` into the ImageBlockUtils POM.
worldomonation May 11, 2023
405c709
Rename POM to CoverBlockUtils
worldomonation May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
- check the src repeatedly to contain the fileBasename instead.
  • Loading branch information
@worldomonation
worldomonation committed May 10, 2023
commit aadc65db9d5009e4b86d011baa31e6fcb95fda26
8 changes: 1 addition & 7 deletions test/e2e/specs/editor/blocks/cover.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,8 @@ test.describe( 'Cover', () => {
// beginning with `blob`.
await expect( async () => {
const src = await coverBlock.locator( 'img' ).getAttribute( 'src' );
expect( src.startsWith( 'http' ) ).toBe( true );
expect( src.includes( fileBasename ) ).toBe( true );
} ).toPass();

const backgroundImageURL = await coverBlock
.locator( 'img' )
.getAttribute( 'src' );

expect( backgroundImageURL ).toContain( fileBasename );
} );

test( 'dims background image down by 50% by default', async ( {
Expand Down