Global Styles: Elements: Add a text decoration control to link elements#45643
Merged
Global Styles: Elements: Add a text decoration control to link elements#45643
Conversation
scruffian
added
the
Global Styles
|
|
noisysocks
reviewed
Nov 9, 2022
packages/edit-site/src/components/global-styles/typography-panel.js
Outdated
Show resolved
Hide resolved
…el.js Co-authored-by: Robert Anderson <robert@noisysocks.com>
|
Size Change: +55 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Nov 9, 2022
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for addressing this one 👍
✅ Text decoration option now available under links element
✅ Setting text decoration for links applies correctly in both the editors and frontend
✅ Text decoration control does not show for other blocks
LGTM 🚢
Contributor
|
I assume this issue can also be closed? |
Contributor
Author
|
No, I don't think so, that's a different issue. |
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This adds a text decoration option to link elements.
Fixes #40002
Why?
The core theme.json file sets a default text decoration for all links. Themes can control this in theme.json but we should make the control available .
How?
Add the text decoration control to Global Styles but only enable it for links.
Testing Instructions
Screenshots or screencast
cc @WordPress/block-themers