Make Manage Reusable blocks match similar links#45641
Merged
noisysocks merged 1 commit intoWordPress:trunkfrom Nov 9, 2022
dsas:update/reusable-blocks-link
Merged
Make Manage Reusable blocks match similar links#45641noisysocks merged 1 commit intoWordPress:trunkfrom dsas:update/reusable-blocks-link
noisysocks merged 1 commit intoWordPress:trunkfrom
dsas:update/reusable-blocks-link
Conversation
The Manage Reusable blocks link inside the reusable blocks inserter should match other similar links such as 'Explore all patterns' on the pattern inserter.
|
|
Contributor
|
I should have mentioned this on the issue itself, but in addition to the appearance of the button, the positioning should match as well. Would it be possible to add this change in a follow-up? Edit: nvm, I see Nik has a PR |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The Manage Reusable blocks link inside the reusable blocks inserter should match other similar links such as 'Explore all patterns' on the pattern inserter.
Why?
User interface consistency. Fixes #45155
How?
This changes a HTML
<a>to a<Button variant=secondary />along with some CSS changesTesting Instructions
Add a reusable block if you haven't already:
Test the change:
Screenshots or screencast