Migrate Manage Reusable Block to Playwright #45621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooja-muchandikar
requested review from
ntwb,
nerrad and
ajitbohra
as code owners
|
|
|
Hi @Mamaduka, I hope you are doing well! I have added explicit wait on Line 50, the reason for this is that the test execution was too fast and further tests were failing, due to that I have added this wait.. I tried in local with other selectors but it didn't help. Let me know if you have any suggestions on same.. Thanks! |
Mamaduka
requested review from
kevin940726 and
Mamaduka
and removed request for
ntwb,
ajitbohra and
nerrad
Mamaduka
added
the
[Type] Automated Testing
kevin940726
reviewed
Jan 2, 2023
|
Hi @kevin940726, I hope you are doing great! I have addressed all the feedbacks and pushed the commit. Please do review and let me know if there are any further feedbacks. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Migrate manage-reusable-blocks.test.js to its Playwright version.
Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test:e2e:playwright test/e2e/specs/editor/various/manage-reusable-blocks.spec.js