Migrate New Default Post Content Test to Playwright #45267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooja-muchandikar
requested review from
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
added
the
[Type] Automated Testing
|
Hi @Mamaduka, I hope you are doing great! Could you please help me in reviewing this PR? The CI has failed but seems like not related to the test case, it's failed because of Unit Tests . Please take a look. Thanks! |
|
The PHPUnit tests should be fixed now #45265. You might want to rebase this branch on top of the trunk. |
|
Hi @Mamaduka, Rebased the branch and now the |
Mamaduka
reviewed
Oct 25, 2022
Mamaduka
reviewed
Oct 25, 2022
Mamaduka
reviewed
Oct 25, 2022
Mamaduka
reviewed
Oct 26, 2022
Mamaduka
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Thank you, @pooja-muchandikar!
The migration looks good. I will merge the changes after all checks are green ✅
|
Thanks for the review @Mamaduka 😊 All Checks have passed successfully 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Migrate new-post-default-content.test.js to its Playwright version.
Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test-e2e:playwright test/e2e/specs/editor/various/new-post-default-content.spec.js