Skip to content

Patch #37754#44995

Open
carlomanf wants to merge 5 commits intoWordPress:trunkfrom
carlomanf:patch-37754
Open

Patch #37754#44995
carlomanf wants to merge 5 commits intoWordPress:trunkfrom
carlomanf:patch-37754

Conversation

@carlomanf
Copy link

What?

Fixes #37754

Based on a precedent in https://core.trac.wordpress.org/changeset/44226 that temporarily removes and then restores the filter.

Happy to answer questions about the implementation design, because I researched a lot of historical discussions and patches and considered a number of different approaches before settling on this one.

Why?

How?

Testing Instructions

Screenshots or screencast

@carlomanf carlomanf requested a review from ajitbohra as a code owner October 15, 2022 10:39
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @carlomanf! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 15, 2022
@christianwach
Copy link

Some discussion of this PR can be found on this WordPress ticket.

@carlomanf
Copy link
Author

I was informed that this patch needs some more work to correctly handle wp_filter_content_tags, specifically to do with its use of an additional $context variable. Unfortunately, I don't have the knowledge of wp_filter_content_tags to be able to address, but anyone else is welcome to.

@github-actions
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Required label: Any label starting with [Type].
  • Labels found: [Feature] Shortcodes, First-time Contributor, [Block] Shortcode.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Shortcode Affects the Shortcode Block [Feature] Shortcodes Related to shortcode functionality First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no_texturize_shortcodes WP filter broken with block themes

3 participants