Inserter: add a more pronounced hover effect.#44711
Merged
Conversation
mtias
added
[Feature] Inserter
jasmussen
approved these changes
Oct 5, 2022
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Nice, works well. I like that it shares footprint DNA (box with round corners) with patterns:
|
Size Change: +89 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Contributor
|
The color contrast doesn't seem great. It looks like it fails AA criterion for small text. Is that something that can be improved? #007cba and #f4f9fc are the hex codes I'm seeing when testing. |
Member
Author
|
I'm using the Modern color palette which has stronger contrast for the primary blue. Hover is more of a decorative effect, so it's less important, but pushed an update to try and handle color schemes were base contrast might be lower. |
mtias
force-pushed
the
try/block-inserter-item-hover-bg
branch
from
753cdba to
c3e9529
Compare
Contributor
|
It's funny how a small design tweak can have dramatic performance gains on some metrics. 👏
|
kevin940726
reviewed
Oct 11, 2022
| right: 0; | ||
| border-radius: $radius-block-ui; | ||
| opacity: 0.04; | ||
| background: var(--wp-admin-theme-color); |
Member
There was a problem hiding this comment.
I think this pseudo element breaks dragging-and-dropping from the inserter in Firefox. (Took me a while to find this! For some reason git blame failed me 😞.)
A simple solution to this would be adding pointer-events: none to the ::after pseudo element.
Member
There was a problem hiding this comment.
I included a fix in #44631 (and added e2e tests for Firefox).
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we are only highlighting the block name on hover in the inserter. This attempts at using a slightly more pronounced effect.