Prevent empty block toolbars from showing empty slots#44704
Merged
youknowriad merged 1 commit intotrunkfrom Oct 5, 2022
Merged
Prevent empty block toolbars from showing empty slots#44704youknowriad merged 1 commit intotrunkfrom
youknowriad merged 1 commit intotrunkfrom
Conversation
youknowriad
added
the
[Type] Bug
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
mtias
approved these changes
Oct 5, 2022
talldan
added
the
Backport to Gutenberg RC
Contributor
|
Thanks for fixing this, and for the related performance improvements ❤️ |
Contributor
|
I just cherry-picked this PR to the release/14.3 branch to get it included in the next release: f218bba |
aaronrobertshaw
pushed a commit
that referenced
this pull request
Oct 12, 2022
aaronrobertshaw
removed
the
Backport to Gutenberg RC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #44642
What?
In #44642 we improved the performance of slot/fills but a small regression was introduced where sometimes empty toolbars show an empty slot like the following screenshot
This was a small mistake due to
valtiousage. This library tracks any object in its state by using a "proxy" to the object itself. SouseSlotFillswas actually returning a proxy to an array instead of the array directly, so it was not considered as "empty".Testing Instructions