Show Letter Spacing in Global Styles -> Typography -> Headings#44142
Merged
noisysocks merged 1 commit intotrunkfrom Sep 16, 2022
Merged
Show Letter Spacing in Global Styles -> Typography -> Headings#44142noisysocks merged 1 commit intotrunkfrom
noisysocks merged 1 commit intotrunkfrom
Conversation
noisysocks
added
[Type] Enhancement
|
Size Change: +23 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Sep 15, 2022
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks sorting this one @noisysocks 👍
✅ Letter spacing control appears under Global Styles -> Typography -> Headings
✅ Letter spacing does not appear under the other root level typography panels
✅ Letter spacing functions appropriately
LGTM!
Screen.Recording.2022-09-15.at.1.49.16.pm.mp4
Member
Author
noisysocks
added
the
Backport to WP 6.9 Beta/RC
ockham
pushed a commit
that referenced
this pull request
Sep 19, 2022
Contributor
|
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: 588eaef |
ockham
removed
the
Backport to WP 6.9 Beta/RC
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Makes Letter spacing (
LetterSpacingControl) appear in Global Styles → Typography → Headings.I split this out from #43356.
Why?
So that the Typography panel in Global Styles looks closer to what was designed in Figma. See #34345 (comment).
How?
Letter spacing was already set up in Global Styles, just not enabled for headings at the global level. To fix this I added a special condition to
useHasLetterSpacingControl.Testing Instructions
Screenshots