Simplify the inserter styles and scrollable#44088
Merged
youknowriad merged 1 commit intotrunkfrom Sep 12, 2022
Merged
Conversation
youknowriad
added
[Type] Enhancement
4 tasks
|
Size Change: +17 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
jasmussen
reviewed
Sep 12, 2022
| date: '2022-09-12T13:28:06', | ||
| date_gmt: '2022-09-12T13:28:06', | ||
| id: 70, | ||
| link: 'http://localhost:8888/?p=70', |
Contributor
Author
There was a problem hiding this comment.
This is in the storybook story, it's not important, I just copied my own reusable blocks :P
Contributor
|
Outside of the new fixtures (left a comment), there's a lot of good refactoring in this one, more red than green. And it works great in my testing, I couldn't break it, with or without temporary scrollbars:
The simpler CSS should be more resilient than the sticky toolbars before. I'd love additional eyes on this one, but I'll happily give this a green check. |
jasmussen
approved these changes
Sep 12, 2022
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and Why?
In #44028 there's a need to add a button at the bottom of the inserter, this is only possible properly if the container of the tab grows to cover all the available space. In order to do that, we also need to move the "scrollable area" of the inserter to be the "tab content" instead of being the whole inserter. This PR achieves this refactoring.
I've also added some Storybook stories which will allow us to work easily on the inserter in isolation.
Testing Instructions
1- Open the main inserter
2- Notice the scrolling behavior is a bit different
3- Try playing with the inserter in different situations, there should be no regression.
You can also run
npm run storybook:devand play with the different inserter stories.Screenshots or screencast