Blocks: remove deprecated node and children matchers#44035
Closed
Blocks: remove deprecated node and children matchers#44035
Conversation
ellatrix
requested review from
ajitbohra,
fluiddot,
nerrad and
ntwb
as code owners
|
Size Change: -464 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Contributor
|
I saw some folks still using these, maybe we should add a message first that these will be removed in say WP 6.3 or something. |
Member
Author
|
Where did you find this? Sure, we can log a message first. It's a bit unfortunate that we forgot to add it back. :) |
Contributor
To be honest I don't remember, some folks were discussing it in a slack or something and I was surprised they were still using it. |
Member
Author
|
I saw we even have some documentation with them, so it's not surprising if people are still using it... I created #44265 to officially deprecated it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
These have been deprecated 4 years ago with #7890.
Turns out the deprecation messages have been removed though, and they've never been restored...
Why?
How?
Testing Instructions
Screenshots or screencast