Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post Date: Add missing typography supports #43340

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Post Date: Add missing typography supports #43340

merged 1 commit into from
Aug 18, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography support to the Post Date block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing typography supports.

Testing Instructions

  1. Edit a post, add a Post Date block and select it.
  2. Test out the text-decoration support ensuring styles are applied in the editor.
  3. Save and confirm the application on the frontend.

Screenshots or screencast

Screen.Recording.2022-08-18.at.10.24.25.am.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Post Date Affects the Post Date Block [Feature] Typography Font and typography-related issues and PRs labels Aug 18, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 18, 2022
@aaronrobertshaw aaronrobertshaw mentioned this pull request Aug 18, 2022
Open
6 tasks
carolinan
carolinan approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, even when the date is a link.

@carolinan carolinan merged commit c9c7c54 into trunk Aug 18, 2022
@carolinan carolinan deleted the add/missing-typography-supports-to-post-date branch August 18, 2022 08:35
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 18, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
@femkreations femkreations mentioned this pull request Oct 3, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinan carolinan carolinan approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Block] Post Date Affects the Post Date Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronrobertshaw @carolinan @femkreations