Conversation
ciampo
requested review from
aaronrobertshaw,
andrewserong,
mirka,
ntsekouras and
talldan
ciampo
added
[Type] Bug
67 tasks
|
Size Change: -3 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Aug 18, 2022
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Thanks for this! I'd noticed the bug at times, but wasn't sure how to reproduce it consistently.
talldan
deleted the
fix/site-editor-remove-scrolbars-when-toolbar-out-of-boundaries
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Tracked in #42770
Set
overflow: hiddenon the site editor wrapper to avoid extra scrollbars showing when the block toolbar scroll past the visible editor canvas' viewport.Why?
When the block toolbar moves "below the fold", a second scrollbar appears — which makes scrolling through the document awkward and, depending on the device and pointer setup, can cause the contents of the site editor to slightly shift sideways.
How?
Setting
overflow: hiddenon.edit-site-visual-editormakes sure that no extra scrollbars are shown.Testing Instructions
Make sure no other regressions are caused by this PR
Screenshots or screencast
trunkKapture.2022-08-17.at.17.26.26.mp4
This PR:
Kapture.2022-08-17.at.17.28.24.mp4